miguelgfierro
commented
1 year ago - [ ] Create a MLOps procedure with tests and GitHub actions. Every time a PR is raised, all the tests need to pass. Follow https://github.com/miguelgfierro/project_template
- [ ] Do a release with release notes following Recommenders or PyTorch.
- [ ] Consider studying whether LightGBM with all the features work better than similarity + business rules (price, etc).
- [ ] Docstring are missing in some functions
- [ ] Add to this repo the code of the front end with the API
- [ ] Do a PR for every feature that is added to the repo
- [ ] See how several people can collaborate https://github.com/yalsaffar/Tourism-Recommendation-System/pull/8#discussion_r1135478435
- [x] Set clearly the members https://github.com/yalsaffar/Tourism-Recommendation-System/issues/9
- [ ] The tag is typically a number, not a string. Here is an example: https://pypi.org/project/lightgbm/#history In this tutorial you can see how to rename a tag https://github.com/miguelgfierro/codebase/wiki/Git-tutorial
- [ ] Some of the commits are not linked to the GitHub account, like this one: https://github.com/yalsaffar/Tourism-Recommendation-System/blob/pre-release/tests/config.py. Make sure you configure your git client. You can follow this guide: https://github.com/Microsoft/Recommenders/wiki/How-to-add-your-name-as-a-contributor-to-the-repo#make-sure-that-your-github-user-is-setup-correctly
- [ ] Remove binary files https://github.com/yalsaffar/Tourism-Recommendation-System/blob/pre-release/lib/web-app/df.csv they can be hosted outside this repo, in a storage or in a different repo just designed for storing data
- [ ] Removed the repeated code. For example https://github.com/yalsaffar/Tourism-Recommendation-System/blob/pre-release/lib/models/model_inital_testing.ipynb and https://github.com/yalsaffar/Tourism-Recommendation-System/blob/pre-release/examples/model_inital_testing.ipynb