Closed jiwooproity closed 3 months ago
@jiwooproity is attempting to deploy a commit to the yamada-ui Team on Vercel.
A member of the Team first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
yamada-colors | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 8, 2024 3:20pm |
Thanks!
Closes #67
Description
I think it cant resolve the problem, but if keep origin color and converting tones it will be resolve
The reason I chose to keep the original color is because the format of hsl has different saturation than hex and rgb, so changes may occur when converted back to hex code.
Current behavior (updates)
A conditional statement to maintain the original color was added to the utils/color.ts/tones function.
Among the 11 colors, the 1st to 5th colors are light and the 7th to 11th colors are dark to maintain the original color.
New behavior
I added conditional statement in utils/color.ts/tones function
Looking at the problem, the 6th color out of 11 colors must maintain the Hex value selected by the user. However, since rgb and hex values ​​may change when converting to hsl, we have added a condition to maintain the original color.
Is this a breaking change (Yes/No):
[No] I just add to conditional statement for keep origin color, and it will convering tones 50 ~ 400, 600 ~ 950 then keep color hex value
Additional Information
I used papago tool,, i cant speak english well sry Please review once!