Correct class name in `Autocomplete` - Githubissues

yamada-ui / yamada-ui

React UI components of the Yamada, by the Yamada, for the Yamada built with React and Emotion.

https://yamada-ui.com

MIT License

810 stars 216 forks source link

Correct class name in `Autocomplete` #1409

Closed illionillion closed 6 months ago

illionillion commented 6 months ago

Which package has an issue?

@yamada-ui/react

Package Version

1.3.9

Description

Corrected the following class names according to BEM

ui-autocomplete__item__icon
- fix to ui-autocomplete__item-icon
ui-autocomplete__item__group-label
- fix to ui-autocomplete__group-label
ui-autocomplete__item__group
- fix to ui-autocomplete__group
ui-autocomplete__field__input
- fix to ui-autocomplete__input

Please be careful of the following when working

Create the changeset with major.
Please derive a new branch from the v2.0 branch and create a pull request for the v2.0 branch, not the main branch, as we plan to release the product in v2.0.0.

Link to Reproduction

No response

Steps to Reproduce

Go to '...'
Click on '...'
Scroll down to '...'
See error

Browser

None

Operating System

[X] macOS
[X] Windows
[X] Linux

Do you know how to fix the issue?

None

Are you willing to participate in fixing this issue and create a pull request with the fix?

None

Additional Information

No response

ghost commented 6 months ago

I would like to challenge this issue.

hirotomoyamada commented 6 months ago

@sacky3105

Hi, thanks for the comment.

It looks like a PR has already been created :(

illionillion commented 6 months ago

This issue is closed.