Deprecated props are being used in the Storybook `FontAwesome` page. - Githubissues

yamada-ui / yamada-ui

React UI components of the Yamada, by the Yamada, for the Yamada built with React and Emotion.

https://yamada-ui.com

MIT License

810 stars 216 forks source link

Deprecated props are being used in the Storybook `FontAwesome` page. #2483

Closed hirotomoyamada closed 3 months ago

hirotomoyamada commented 3 months ago

Which package has an issue?

@yamada-ui/react

Package Version

1.4.8

Description

Deprecated props are being used in the Storybook FontAwesome page.

Use fontSize instead of size.

Link to Reproduction

No response

Steps to Reproduce

Go to '...'
Click on '...'
Scroll down to '...'
See error

Browser

None

Operating System

[ ] macOS
[ ] Windows
[ ] Linux
[ ] iPadOS
[ ] iOS
[ ] Android

Do you know how to fix the issue?

None

Are you willing to participate in fixing this issue and create a pull request with the fix?

None

Additional Information

No response

chida09 commented 3 months ago

can i work this issue?

maybe I'll fix the section of code below.

https://github.com/yamada-ui/yamada-ui/blob/1473921f8aeb4e2040d0337aee3b101e78884749/stories/components/media-and-icons/font-awesome.stories.tsx#L18-L28

hirotomoyamada commented 3 months ago

@chida09

Hi, thanks for the comment!

Yes, pls!

Those lines are correct.