yamada-ui / yamada-ui

React UI components of the Yamada, by the Yamada, for the Yamada built with React and Emotion.
https://yamada-ui.com
MIT License
810 stars 216 forks source link

Fix incomplete sentence in @media documentation #2776

Closed odendayoko closed 2 months ago

odendayoko commented 2 months ago

Provide the exact quote of the error or issue

In the documentation explaining the usage of @media , there is an incomplete sentence.

English:

For example, to change the styles displayed in print preview mode using the print media type of @media,

Japanese:

例えば、@mediaのメディア種別のprintを使い、印刷プレビューモードで表示されるスタイルを変更する場合は、

Does the docs page already exist? Please link to it.

https://yamada-ui.com/styled-system/at-rules#media

Are you willing to participate in fixing this issue and create a pull request with the fix?

None

hirotomoyamada commented 2 months ago

@odendayoko

Hi, thanks for the issue.

How do you think the above sentence should be modified?

odendayoko commented 2 months ago

@hirotomoyamada Sorry!! I would like you to complete the sentence.

English:

For example, here is an example of using @media's media type print to change the style displayed in print preview mode.

Japanese:

例えば、@mediaのメディア種別のprintを使い、印刷プレビューモードで表示されるスタイルを変更する場合の例です。
hirotomoyamada commented 2 months ago

@odendayoko

Hi, thanks for the comment!

I would like to make this change.

English:

For example, to use the `@media` media type `print` and change the style displayed in print preview mode, set `type` to `"print"`.

Japanese:

例えば、`@media`のメディア種別の`print`を使い、印刷プレビューモードで表示されるスタイルを変更する場合は、`type`に`"print"`を設定します。