yamada-ui / yamada-ui

React UI components of the Yamada, by the Yamada, for the Yamada built with React and Emotion.
https://yamada-ui.com
MIT License
809 stars 216 forks source link

`displayName` is not set for the component of "@yamada-ui/icon" #2870

Closed hirotomoyamada closed 1 month ago

hirotomoyamada commented 1 month ago

script: component-display-name package: @yamada-ui/icon

Description

The component "@yamada-ui/icon" uses forwardRef, but displayName is not set, making it difficult to see the display in React Developer Tools.

Additional Information

Set displayName and __ui__ after each component definition.

For example, like this.

const Component = forwardRef((props, ref) => {
  ...
})

Component.displayName = 'Component'
Component.__ui__ = 'Component'

Replace 'component' with the name of the component. For example, for a Select component, it is 'Select'.

__ui__ is an identifier required for internal use by Yamada UI. Be sure to set it together with displayName.

KekmaTime commented 1 month ago

Hi @hirotomoyamada

I noticed several displayName issues, and I think a task list could help track them better. If you'd like, I can help by creating a task list to organize everything.

hirotomoyamada commented 1 month ago

@KekmaTime

Hi, thanks for the comment!

Are you perhaps referring to milestones or projects?

KekmaTime commented 1 month ago

@KekmaTime

Hi, thanks for the comment!

Are you perhaps referring to milestones or projects?

Yesyes that's what I meant😅

hirotomoyamada commented 1 month ago

@KekmaTime

I see!

However, these tasks are coming to an end, so I won't do them this time! I will do so next time!

Thanks :)