search

yamankatby / react-native-material

Modular and customizable Material Design UI components for React Native
https://rn-material.js.org
MIT License
223 stars 38 forks source link

Fix: #34 useNativeDriver default to false #35

Closed justJay-dev closed 1 year ago

justJay-dev commented 2 years ago

hey there! Finally got my local working.

Included here is just a simple change to move everything using Animated.timing to useNativeDriver false, it looks like you had started to parse out some logic based on platform, but I am not privvy to what your aims are there, safer to default to false given you had some expressly set false prior to this change.

Cheers!

justJay-dev commented 2 years ago

Hey just checking in, are we good to merge this?

yamankatby commented 2 years ago

Hey @justJay-dev, Very sorry for not having time to actively maintain this repo. I'll find time to merge this PR later this week.

btw, I can add you as a collaborator, so you own a part of the repo. It'll be a super great help if you have time. Just tell me if you want.

pigpudle commented 1 year ago

Can you please merge it?

yamankatby commented 1 year ago

Hi there, Just merged, soon to npm 🙌

souzaluiz commented 1 year ago

still happening in version 1.3.7