Closed kabouzeid closed 2 years ago
Again, setting the descent to 40 fixes it:
diff --git a/.fantasticonrc.js b/.fantasticonrc.js
index e8c61e3..519d10d 100644
--- a/.fantasticonrc.js
+++ b/.fantasticonrc.js
@@ -5,6 +5,7 @@ module.exports = {
pathOptions: {
json: "./src/template/nonicon.json",
},
+ descent: 40,
codepoints: {
"alert-16": 61697,
"angular-16": 61698,
To reproduce, you can for example open dist/nonicons.html
in your browser and hover over the icons with your browser debugging tools. You can also clearly see it just by looking at it:
Without descent the icons are not centered, but top aligned.
With descent: 40 the icons are perfectly centered
I also encounter this issue using kitty. @kabouzeid 's patch did fixed my issue.
@kabouzeid Thank you for your report. I have added the corrections you have proposed! please make sure!
Thank you 🙏
So with the latest releases I have this problem again: https://github.com/yamatsum/nonicons/pull/11#issuecomment-840454411
3334b8db9417aa0ba5f0ad5da0748a421dd7806d is the last commit where the
dist/nonicons.ttf
file is working. Note however that when I checkout this commit and runyarn update
again, then this file changes, and is then also misaligned!