search

yambo-code / yambo

This is the official GPL repository of the yambo code
http://www.yambo-code.eu/
GNU General Public License v2.0
99 stars 39 forks source link

Fix bug in str_trimm PARSER.c #112

Closed muralidhar-nalabothula closed 4 months ago

muralidhar-nalabothula commented 4 months ago

This along with https://github.com/yambo-code/Ydriver/pull/2 will fix memory bugs in the parser. Now running -fsanitize=address should not crash as mentioned in the issue https://github.com/yambo-code/yambo/issues/111

Additionally, this should fix other bugs when parsing (for ex segmentation faults when giving large number of bands/ kpoints in ypp band interpolation or building QP databases)

sangallidavide commented 4 months ago

Thanks @muralidhar-nalabothula

sangallidavide commented 4 months ago

I also merged the pull request in Ydriver.

Todo: tag a new driver version and change the corresponding tag-version inside the file https://github.com/yambo-code/yambo/blob/maintenance-master/lib/archive/package.list