search

yambo-code / yambo

This is the official GPL repository of the yambo code
http://www.yambo-code.eu/
GNU General Public License v2.0
91 stars 35 forks source link

A build with --enable-etsf-io fails if the Yambo has to download etsf-io itself in Yambo 4.5.3 #29

Closed klust closed 3 years ago

klust commented 3 years ago

The build process fails to download the etsf-io package. TThe cause is a download failure, leaving an empty file.

The download is done by the Makefile in lib/archive. On our system, this executes the command

wget --no-check-certificate -O etsf_io-1.0.4.tar.gz https://github.com/yambo-code/yambo/files/845218/

This is not what is intended, and the cause is a typo in package.list. Line 56 (line number for Yambo 4.5.3) should read

url_etsf_io=https://github.com/yambo-code/yambo/files/845218/$(tarball_etsf_io)

(the _io at the end is missing).

The mistake in package.list is still present in the version that I found in the repo on 3 February 2020, but is now on line 70.

sangallidavide commented 3 years ago

Thanks for reporting this.

The reason why it was left there is that etsf-io library is in practice not used anymore and should be removed (together with the --enable-etsf-io option) in the future

I'll fix the issue anyway to avoid confusion.

sangallidavide commented 3 years ago

Fixed in branch 4.5 with commit 4ae3985