yambo-code / yambo

This is the official GPL repository of the yambo code
http://www.yambo-code.eu/
GNU General Public License v2.0
98 stars 38 forks source link

rim subroutine is buggy, since it has an optional variable, but it is not an interface #67

Closed sangallidavide closed 7 months ago

sangallidavide commented 8 months ago

After version 5.2 the subroutine was changed introducing Xw as optional variable.

However such a change would require to define an interface in a module

!

-subroutine rim(mode)
+subroutine rim(mode,Xw)
  !
  use pars,          ONLY:SP,pi,DP
  use com,           ONLY:msg
@@ -20,6 +20,7 @@ subroutine rim(mode)
 &                        RIM_id_epsm1_reference,RIM_anisotropy,RIM_W,&
 &                        cut_is_slab,idir
  use timing_m,      ONLY:timing
+ use frequency,     ONLY:w_samp
  !
 #include<memory.h>
  !
@@ -27,9 +28,10 @@ subroutine rim(mode)
  !
  ! Work Space
  !
- type(PP_indexes)::px
- integer   :: iq
- real(SP)  :: em1_anis(3),G_radii,G_circ
+ type(PP_indexes)      ::px
+ type(w_samp),optional :: Xw
+ integer               :: iq
sangallidavide commented 8 months ago

Fixed with commit fc8c149

The variable Xw is not optionial