search

yamcs / python-yamcs-client

Yamcs Client for Python
https://docs.yamcs.org/python-yamcs-client/
GNU Lesser General Public License v3.0
16 stars 11 forks source link

It would be good to support requests.Session() verify='/path/to/certfile' option #14

Closed AdamElliott-AB closed 3 years ago

AdamElliott-AB commented 3 years ago

The requests library has an option to specify the location of a custom certificate to use when doing certificate verification. This library however only allows tls_verify to be True or False. We can use the REQUESTS_CA_BUNDLE environment variable for this purpose but supporting having a tls_verify='/path/to/certfile' option would be preferred.

https://docs.python-requests.org/en/master/user/advanced/#ssl-cert-verification

https://github.com/yamcs/python-yamcs-client/blob/dec6bb3dab26aeb520e7f43e8406bf7928fcb084/yamcs-client/src/yamcs/core/context.py#L20

https://github.com/yamcs/python-yamcs-client/blob/dec6bb3dab26aeb520e7f43e8406bf7928fcb084/yamcs-client/src/yamcs/core/context.py#L41

fqqb commented 3 years ago

On master, and included in latest release.

AdamElliott-AB commented 3 years ago

Wonderful! Thank you.