yamcs / yamcs-studio

Desktop TM/TC Client for Yamcs
https://docs.yamcs.org/yamcs-studio/
Eclipse Public License 2.0
27 stars 14 forks source link

Events source filter #110

Closed lorenzo-gomez-windhover closed 3 years ago

lorenzo-gomez-windhover commented 3 years ago

Hello everyone,

Hope you are all doing well.

We've always enjoyed the source event filter that exists on yamcs WebApp, and it was was always unfortunate that the feature was not in Studio as well.

I have added an events source filter to the EventsLog toolbar. I tried my best to follow the same patterns in EventLogSeverityFilter. The only wrinkle in this filter is that since I wanted the dropdown box to have sources up to date just like the WebApp does, I took the liberty of tweaking the pattern accordingly. Hopefully there aren't red flags in he way I implemented it.

Cheers Lorenzo

fqqb commented 3 years ago

Thanks LGTM.

I did two things on top of your work:

BTW: I'm noticing that the clear button is not working when a filter has been used. It seems independent of your commit (happens for both severity filter and source filter), so I will look into it later (doesn't appear to be a quick fix).