fqqb
commented
1 year ago Freeze/crash is bad. I would expect that it just disconnects the client. We refer to the WebSocket connection to determine if a client is connected. Even in the case of a hard crash of the server, that should close eventually due to heartbeat mechanism. But from your description, seems something going wrong there for sure.
About #112, auto reconnection would first require some work on the server. When there's no auth this is quite straightforward, but when there is, it requires the server to somehow keep track of authentication sessions so that they can be restored. This is especially important for the standard token flow, where user passwords are only accessed once on the first login (then exchanged for tokens). I have been making moves towards that (introduction of "Admin Area > Sessions" page), but needs more work.
We're actively investigating an issue with YAMCS Studio freezing up if the main YAMCS instance, itself, is restarted or crashes.
We can continue our internal investigation, but I was wondering if this is a supported usecase or a known issue before we go much further.
We originally thought it was related to https://github.com/yamcs/yamcs-studio/issues/113
I think it might be at the root of this request: https://github.com/yamcs/yamcs-studio/issues/112
More notes to come