search

yamcs / yamcs

A framework for mission control
https://yamcs.org
GNU Affero General Public License v3.0
180 stars 76 forks source link

Abstract metacommands in XTCE can still be sent #357

Closed merose closed 4 years ago

merose commented 4 years ago

To reproduce:

  1. Use an XTCE command configuration that includes an abstract command.

    ...

  2. In the YAMCS web interface, go to Commanding > Send a Command.

  3. Select the abstract command (BASE_COMMAND), enter any arguments, and press Send.

Actual result: Command is sent.

Expected result: User should not be able to send the abstract command. Unclear exactly what the UI should be, but perhaps the abstract commands should not be in the list of commands in the "1. Select command" step.

xpromache commented 4 years ago

Looks like the abstract attribute of the MetaCommand was not read from the xml, fixed with 0b7202b.