yami-beta / asyncomplete-omni.vim

Omni completion source for asyncomplete.vim
MIT License
39 stars 11 forks source link

feat: Add `o` label to `kind` #14

Closed yami-beta closed 4 years ago

yami-beta commented 5 years ago

ref. #13

jsit commented 4 years ago

This looks great, except I wonder if it should be o inside of the kind attribute. From :h complete-items

word            the text that will be inserted, mandatory
abbr            abbreviation of "word"; when not empty it is used in
                the menu instead of "word"
menu            extra text for the popup menu, displayed after "word"
                or "abbr"
info            more information about the item, can be displayed in a
                preview or popup window
kind            single letter indicating the type of completion

asyncomplete has been indicating the completion type with a word in square brackets, but this would be more in keeping with how Vim intends these menus to appear, it seems.

jsit commented 4 years ago

Maybe something like #22

yami-beta commented 4 years ago

I merged #22 Is there anything else you would like to change?

jsit commented 4 years ago

Looks great, thanks!