Open adriantache opened 5 years ago
I can not find the resource files in compileSDK of 28
I can not find the resource files in compileSDK of 27
Is there any update about this problem? To build my application with the release config, i needed to ste the compileSdkVersion on ~/node_modules/react-native-orientation/android/build.gradle to 26.
Would be a problem, merge a PR setting this version to 26?
Use a fork react-native-orientation-locker with normal support ! :+1:
@retyui im already using this fork. I think this repo is dead. But because of the number of stars, or other thing this is the first repo that everyone finds. :(
There is a simple solution for this, courtesy of @RoJoHub:
You can override this settings by adding a Project-wide gradle configuration
properties for use by all modules in your ReactNative project by adding the
below to android/build.gradle file,
buildscript {...}
allprojects {...}
/**
* Project-wide gradle configuration properties for use by all modules
*/
ext {
compileSdkVersion = 26
targetSdkVersion = 26
buildToolsVersion = "26.0.2"
googlePlayServicesVersion = "12.0.1"
googlePlayServicesVisionVersion = "15.0.2"
supportLibVersion = "27.1.0"
}
@MateusAndrade we can mention all peoples who set star to this repo and tell them to unstar it )
@adriantache I have a better solution
android/build.gradle
subprojects { subProject ->
afterEvaluate {
if (subProject.hasProperty("android")) {
android {
buildToolsVersion "28.0.2"
compileSdkVersion 28
}
}
}
}
@retyui i think this is a good idea. Since this repo wont get any update for a long time. Another option would be open a issue warning to this problem, and showing the orientation-locker fork
There is a simple solution for this, courtesy of @RoJoHub:
You can override this settings by adding a Project-wide gradle configuration properties for use by all modules in your ReactNative project by adding the below to android/build.gradle file, buildscript {...} allprojects {...} /** * Project-wide gradle configuration properties for use by all modules */ ext { compileSdkVersion = 26 targetSdkVersion = 26 buildToolsVersion = "26.0.2" googlePlayServicesVersion = "12.0.1" googlePlayServicesVisionVersion = "15.0.2" supportLibVersion = "27.1.0" }
YES.This is a good wat to solve.But must be support by author.
Also i think @retyui .That is good idea.
But we may need to pay attention to some side effects, because the configuration of all sub-projects has been changed.
@retyui @RoJoHub i created this issue #343 about this problem and the fact that this repo wasnt updated after a longe time. Hope it helps any off you guys! :)
I have no idea why this needs all those visual elements, but the app won't compile unless I manually edit the build.gradle for react-native-orientation to use a compileSdk of 26.