search

yamin8000 / freeDictionaryApp

freeDictionaryApp or free Dictionary App is a simple android application for freeDictionaryAPI. (a reincarnation of https://github.com/yamin8000/Owl2) implemented using Kotlin and Jetpack Compose
GNU General Public License v3.0
101 stars 2 forks source link

Material icons. #48

Closed mischievouus closed 9 months ago

mischievouus commented 9 months ago

Could you please add in material you icons 💜 thankyouuu.

yamin8000 commented 9 months ago

material you icons

What do you mean exactly?
This app already uses Material Icons from Google. I don't think there's any specific Material You Icons.

mischievouus commented 9 months ago

Screenshot_20231217-212736

The app doesn't use material you themes when the user has them enabled. Which sadly makes me have to stop using apps that don't support it. So I'm hoping you can make the relevant changes.

Thankyou for taking the time to review this issue, I know it's not a priority for most people. But for me it is. 💜

yamin8000 commented 9 months ago

Screenshot_20231217-212736

The app doesn't use material you themes when the user has them enabled. Which sadly makes me have to stop using apps that don't support it. So I'm hoping you can make the relevant changes.

Thankyou for taking the time to review this issue, I know it's not a priority for most people. But for me it is. 💜

Ok, I understand. That's called a themed app icon or adaptive icon.
Yeah, I'll do it.

mischievouus commented 9 months ago

Thankyou so much, great work with the app btw, it's visually stunning. 💜

yamin8000 commented 9 months ago

Thankyou so much, great work with the app btw, it's visually stunning. 💜

Well, my phone's launcher doesn't support the Material You Icon pack so I can't test the new feature.
What's your launcher?

yamin8000 commented 9 months ago

Thankyou so much, great work with the app btw, it's visually stunning. 💜

Please test the last version.

mischievouus commented 9 months ago

It is working, great job. Looks so much better on my phone, I appreciate it so much 💜

mischievouus commented 9 months ago

Screenshot_20231218-010100

yamin8000 commented 9 months ago

It is working, great job. Looks so much better on my phone, I appreciate it so much 💜

I'm glad you liked it.
Thank you for your suggestion.