search

yamin8000 / freeDictionaryApp

freeDictionaryApp or free Dictionary App is a simple android application for freeDictionaryAPI. (a reincarnation of https://github.com/yamin8000/Owl2) implemented using Kotlin and Jetpack Compose
GNU General Public License v3.0
70 stars 2 forks source link

[Feature Request] Oled theme #54

Closed Toiletmason closed 5 months ago

Toiletmason commented 6 months ago

Would be a nice addition to the app.

yamin8000 commented 6 months ago

Would be a nice addition to the app.

https://github.com/yamin8000/freeDictionaryApp/releases/tag/1.5.7 Temporarily I added a WIP OLED theme that is only relative to the app's dark theme so if your device's system-wide theme is dark and the app theme is set to system/dynamic then OLED is not applied.

Toiletmason commented 6 months ago

I'm using oneui 5.1 android 13 and it is like you said. It doesn't work for me.

yamin8000 commented 6 months ago

I'm using oneui 5.1 android 13 and it is like you said. It doesn't work for me.

Did you change the app's theme in the app settings?

Toiletmason commented 6 months ago

Screenshot_20231226_171029_freeDictionary.jpg

yamin8000 commented 6 months ago

Screenshot_20231226_171029_freeDictionary.jpg

Do you expect darker than this?

Toiletmason commented 6 months ago

An oled theme is generally #000000 black and uses a darker grey to show headers and stuff. I'll show you a screenshot of audile which is an open source music recognition app. Screenshot_20231227_015509_Audile.jpg

This is an example of what I was expecting. Thank you for listening. I'm not trying to be a bother.😅

yamin8000 commented 6 months ago

An oled theme is generally #000000 black and uses a darker grey to show headers and stuff. I'll show you a screenshot of audile which is an open source music recognition app. Screenshot_20231227_015509_Audile.jpg

OK, I'll reconsider this feature change.

yamin8000 commented 6 months ago

@Toiletmason Did you try the latest version? I darkened the OLED theme more. Is that what you view as a genuine OLED theme?

Toiletmason commented 6 months ago

@yamin8000 Yes sir. There are a couple of things I might have done differently, but it's your app my man. Maybe use some of the color you used for the icon and make some lines pop. Idk.

Great work and thanks for taking my input into consideration.

Toiletmason commented 5 months ago

@yamin8000

After the update it seems like the background isn't truly black anymore. The borders look sick, but any chance you can make the background #000000 black? On oled screens the pixels emit no light.

yamin8000 commented 5 months ago

@yamin8000

After the update it seems like the background isn't truly black anymore. The borders look sick, but any chance you can make the background #000000 black? On oled screens the pixels emit no light.

I didn't change the background for OLED in this version and it was never #000000 black in the first place.
The OLED theme is still temporary in my view and even its implementation is buggy.
Unfortunately I don't have an OLED device so it looks black enough to me.
I'll work on it, I should set the background to pitch black manually.

yamin8000 commented 5 months ago

@yamin8000

After the update it seems like the background isn't truly black anymore. The borders look sick, but any chance you can make the background #000000 black? On oled screens the pixels emit no light.

https://github.com/yamin8000/freeDictionaryApp/releases/tag/1.5.91