search

yamin8000 / freeDictionaryApp

freeDictionaryApp or free Dictionary App is a simple android application for freeDictionaryAPI. (a reincarnation of https://github.com/yamin8000/Owl2) implemented using Kotlin and Jetpack Compose
GNU General Public License v3.0
70 stars 2 forks source link

Splash screen background by theme #78

Closed nvllz closed 4 months ago

nvllz commented 5 months ago

Hi, I just got flashed when wanted to search for some term clarification within your great app. For better experience, the splash screen background color should match the current theme setting.

yamin8000 commented 5 months ago

Hi, I just got flashed when wanted to search for some term clarification within your great app. For better experience, the splash screen background color should match the current theme setting.

Hi. Thank you. I just want to clarify something, did you experience a white flash during launch/splash or after the app is opened and you're searching for a new term?

nvllz commented 5 months ago

It's the splash screen (background when opening the app) which is always white regardless of the current theme. When using dark theme it would be good to have it black to prevent such cases.

yamin8000 commented 4 months ago

It's the splash screen (background when opening the app) which is always white regardless of the current theme. When using dark theme it would be good to have it black to prevent such cases.

Hmm. That never happens to me. Which version of Android you are using?

nvllz commented 4 months ago

Android 13, you can learn more here: https://developer.android.com/develop/ui/views/launch/splash-screen

yamin8000 commented 4 months ago

Android 13, you can learn more here: https://developer.android.com/develop/ui/views/launch/splash-screen

Thanks. I'll look into it.

yamin8000 commented 4 months ago

Android 13, you can learn more here: https://developer.android.com/develop/ui/views/launch/splash-screen

TL;DR;
Hell, I added it anyway.

One big problem with that splash screen is its complete disregard for the Jetpack Compose Theme System. This type of Splash Screen still relies on XML configuration while Jetpack Compose apps' colors are defined inside Kotlin codes so its config is always prone to be out of sync with app theme colors also it's not aware of the app's current theme so its understanding of whether an app is in dark mode or light mode is based on device dark/light setting.

nvllz commented 4 months ago

You are right, I learned it recently too. But it's still a big upgrade, will definitely prevent those unexpected flashes at night.

Thanks for your efforts!