Open matttbe opened 2 years ago
It looks like the error reported by the CI is not due to this modification:
Step 1/8 : FROM fedora:25
25: Pulling from library/fedora
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
Without this PR, a warning is emitted when compiling libyaml with musl libc:
If the warning is ignored (default behaviour), a program using libyaml starts but crashes because
strdup()
is returning garbage:The solution is to follow
strdup()
's manpage and define_GNU_SOURCE
before includingstring.h
.I guess when using other libc, it fallbacks to another version or maybe
_GNU_SOURCE
is set by default but it certainly uses a validstrdup
.Fixes: 625fcfe ("Refactor internal and external API.")