search

yaml2sbml-dev / yaml2sbml

Tool to convert an ODE model specified in the YAML format to SBML.
https://yaml2sbml.readthedocs.io/en/latest/
Other
12 stars 7 forks source link

Logo not rendering on README #102

Closed martamatos closed 3 years ago

martamatos commented 3 years ago

In the develop branch: image

Shouldn't the logo be rendering there?

yannikschaelte commented 3 years ago

It's a fully qualified link targeting the master branch, bc otherwise it would not show on pypi. It should show everywhere once it's merged to the main branch.

yannikschaelte commented 3 years ago

Oh, but @martamatos there is indeed a problem: The link should contain /main/, not /master/.

martamatos commented 3 years ago

It still seems smart enough to go to main automatically: https://github.com/yaml2sbml-dev/yaml2sbml/blob/main/doc/logo/logo_yaml2sbml_long.png Is the 404 error still expected?

yannikschaelte commented 3 years ago

Ah good, then it should in principle work. Yes, the 404 is expected until develop is merged into main.