search

yaml2sbml-dev / yaml2sbml

Tool to convert an ODE model specified in the YAML format to SBML.
https://yaml2sbml.readthedocs.io/en/latest/
Other
12 stars 7 forks source link

fix #99 fix #107 #109

Closed jvanhoefer closed 3 years ago

codecov-io commented 3 years ago

Codecov Report

Merging #109 (a74b3fb) into develop (3c45897) will increase coverage by 8.61%. The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #109      +/-   ##
===========================================
+ Coverage    77.85%   86.46%   +8.61%     
===========================================
  Files            5        5              
  Lines          429      436       +7     
===========================================
+ Hits           334      377      +43     
+ Misses          95       59      -36
Impacted Files Coverage Δ
yaml2sbml/yaml_validation.py 89.65% <77.77%> (+17.65%) :arrow_up:
yaml2sbml/yaml2sbml.py 82.83% <84.61%> (+7.45%) :arrow_up:
yaml2sbml/YamlModel.py 84.39% <100.00%> (-0.09%) :arrow_down:
yaml2sbml/yaml2PEtab.py 93.93% <100.00%> (+23.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0cbcf9...a74b3fb. Read the comment docs.

jvanhoefer commented 3 years ago

This fixes two issues when parsing a model (starting minus signs and identifiers, that are not valid SBML identifiers). For the SBML identifiers it is harder to check, so I for the moment only clarified the format specs there.