search

yaml2sbml-dev / yaml2sbml

Tool to convert an ODE model specified in the YAML format to SBML.
https://yaml2sbml.readthedocs.io/en/latest/
Other
12 stars 7 forks source link

Unfix AMICI version #113

Closed dilpath closed 3 years ago

dilpath commented 3 years ago

closes https://github.com/yaml2sbml-dev/yaml2sbml/issues/90

codecov-io commented 3 years ago

Codecov Report

Merging #113 (60ee63c) into develop (3c45897) will increase coverage by 9.30%. The diff coverage is 84.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #113      +/-   ##
===========================================
+ Coverage    77.85%   87.15%   +9.30%     
===========================================
  Files            5        6       +1     
  Lines          429      475      +46     
===========================================
+ Hits           334      414      +80     
+ Misses          95       61      -34
Impacted Files Coverage Δ
yaml2sbml/YamlModel.py 84.00% <77.77%> (-0.49%) :arrow_down:
yaml2sbml/yaml_validation.py 89.65% <77.77%> (+17.65%) :arrow_up:
yaml2sbml/yaml2sbml.py 85.18% <80.95%> (+9.80%) :arrow_up:
yaml2sbml/__init__.py 100.00% <100.00%> (ø)
yaml2sbml/version.py 100.00% <100.00%> (ø)
yaml2sbml/yaml2PEtab.py 94.17% <100.00%> (+23.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9923197...60ee63c. Read the comment docs.

jvanhoefer commented 3 years ago

@dilpath Any idea, what is going wrong here? :)

dilpath commented 3 years ago

@dilpath Any idea, what is going wrong here? :)

Yes, there's an issue with AMICI related to piecewise functions that have time-independent conditions. I received some advice from @paulstapor on how to fix this today, hopefully I can get to it within the next week.