search

yamldb / yaml_db

Rails plugin for a database-independent dump format, data.yml .......... Seeking new maintainers! See https://github.com/yamldb/yaml_db/issues/143
https://rubygems.org/gems/yaml_db
949 stars 200 forks source link

Order HABTM tables using both ids #74

Closed mauriciopasquier closed 7 years ago

mauriciopasquier commented 9 years ago

I've been using yaml_db for backups in git and to generate seed data, and this patch has been really useful to avoid a lot of noise from reorderer rows in join tables. It just assumes that if the first and second columns end with _id, it's a join table and uses the second column in the ordering. If they don't, it's harmless.

mauriciopasquier commented 9 years ago

comments?

mauriciopasquier commented 8 years ago

Bump! I think it's a trivial change, checks are green and is tested. Let me know if I can do something to merge this, please.

mauriciopasquier commented 7 years ago

I just rebased on master. I would love to have this merged and stop using my fork, any thoughts about it?

dnrce commented 7 years ago

Thanks @mauriciopasquier, and sorry for the way overdue review of this. Added a couple minor comments. When fixed I'll be happy to merge.

mauriciopasquier commented 7 years ago

Thanks for reviewing! Don't worry about the delay. You're right about all your remarks. I pushed a fix, let me know if it's ok and I'll rebase

mauriciopasquier commented 7 years ago

Fixed, also rebased with master and to a single commit.

dnrce commented 7 years ago

This looks great. Thanks, @mauriciopasquier!

mauriciopasquier commented 7 years ago

No problem, thanks for merging and maintaining!

dnrce commented 7 years ago

I'll cut a release soon but I'm going to try to close #109 first.

dnrce commented 7 years ago

Released yaml_db 0.5.0.

mauriciopasquier commented 7 years ago

Awesome, thanks!