yammer / breakerbox

Frontend for Tenacity + Archaius
Apache License 2.0
63 stars 29 forks source link

The instances aren't synchronising after configuration change #13

Open Vishal-Joshi opened 8 years ago

Vishal-Joshi commented 8 years ago

Hi,

I have some instances in a cluster and I see that they don't get synchronised after I update some hystrix configurations even after the 'delay' time duration. The reason I found is we have to select 'Execution Isolation Strategy' so that the instances start taking the new configurations. There is no pointer to the user about why instances are being shown Unsynchronised.

The 'Execution Isolation Strategy' should come selected by default.

Regards, Vishal Joshi

chrisgray commented 8 years ago

You're definitely right in that they aren't appearing to be synchronized until you select a "Execution Isolation Strategy".

To be clear, the instances are synchronizing each of the individual settings just Breakerbox isn't giving you that full 100% synchronized because the execution isolation strategy isn't set Breakerbox side.

This was done intentionally because we added the ability to configure Execution Isolation Strategy later. So you might have multiple configurations in the past without it being set explicitly by a user. In order to set it for you Breakerbox would have to "auto-fill" this field if it's absent Breakerbox side from configurations it's retrieving from the remote instance(s).

I'll go ahead and make this an issue to be fixed in a future release. I agree that this will help with clarity and confusion around whether or not a configuration is synchronized or not.