Cannot configure turbine.stream url in mustache template

boicy commented 10 years ago

Hey,

We are trying to deploy breakerbox behind an nginx proxy and are running into some problems with the localhost:8080/turbine.stream that is hardcoded into the dashboard.mustache template.

<iframe id="tenacity-dashboard-iframe"
        seamless
        class="col-lg-12"
        style="height: 100%; width: 100%; min-height: 1200px"
        src="/assets/monitor/monitor.html?delay=1000&stream=localhost%3A8080%2Fturbine.stream%3Fcluster%3D{{clusterName}}"></iframe>

This potentially causes two problems:

If the port is different when behind a proxy
If you change the server port in breakerbox.yml it isn't picked up by the turbine config.

We looked at writing a test for this, but there didn't seem to be an easy way to test the templating and didn't want to suddenly add a load of acceptance test code to the project. If you would like us to do that, we would be happy to.

Cheers,

James / Praveena (pairing)

chrisgray commented 10 years ago

Sorry for the late reply @boicy ! If you have pull request ready to go. I'd be happy to review and merge it! Otherwise I can go ahead and make the "src" here a configurable portion.

chrisgray commented 10 years ago

Here's a fix @boicy

https://github.com/yammer/breakerbox/commit/682f79662810fa2bf1ab7f246142566679f19b7f

yammer / breakerbox

Cannot configure turbine.stream url in mustache template #2