Adding support for restricting users to specific groups

yammer / dropwizard-auth-ldap

Dropwizard Authentication Module for LDAP using JNDI.

Apache License 2.0

36 stars 18 forks source link

Adding support for restricting users to specific groups #1

Closed reines closed 10 years ago

reines commented 10 years ago

This adds support for restricting users to specific LDAP groups, however:

My LDAP knowledge is poor, is this generic enough, or likely to be specific to our LDAP setup?
This changes the use of the securityPrincipal field in the configuration and will require any clients to change.

msurdi commented 10 years ago

I would externalise the templates used for the queries if possible, like "(&(memberUid=%s)(|%s))" or "ou=groups,%s" to a configuration file and/or constructor parameters. These values might vary between different LDAP servers and configurations.

msurdi commented 10 years ago

Great!! These changes will just make it more useful to a lot of people. Thanks!