yammer / dropwizard-auth-ldap

Dropwizard Authentication Module for LDAP using JNDI.
Apache License 2.0
36 stars 18 forks source link

Support for full DN of the user in the member field when used with groupOfNames object class #5

Closed d-lorenc closed 8 years ago

d-lorenc commented 9 years ago

I found out that the current implementation seems to assume that groups are defined using posixGroup/memberUID, where memberUID is a short unique user ID. As I'm using groupOfNames for groups in LDAP I had to make it work with a member field which has to be defined as a full DN of the user. It's a small change, and others might find it useful too, so the pull request. Sorry for no unit tests, but your current structure didn't allow me to test it - that's my excuse :) However I've tested that change in my project in more end2end scenario and all my functional tests are green now.

chrisgray commented 9 years ago

Maybe we can add in the ability to switch the fullDN based on a configuration parameter rather than magical group member fields?