yammer / mcrouter-build-docker

An Ubuntu 12.04 package builder for mcrouter
Other
4 stars 3 forks source link

14.04 #2

Closed kevinquinnyo closed 8 years ago

kevinquinnyo commented 8 years ago

I don't expect you to merge this in yet. It's just here for reference to https://github.com/yammer/mcrouter-build-docker/issues/1 .

If you did merge it however, nothing should change for you except that the .deb file will be located in ./12.04/ instead of ./

kevinquinnyo commented 8 years ago

That would be ideal.

bmorton commented 8 years ago

I noticed that this was just added to Docker 1.9 for build-time arguments. I think this might be exactly what we need here.

kevinquinnyo commented 8 years ago

closing as I'm going to submit a new PR based on your improvements