search

yammer / mcrouter-build-docker

An Ubuntu 12.04 package builder for mcrouter
Other
4 stars 3 forks source link

14.04 support #3

Open kevinquinnyo opened 8 years ago

kevinquinnyo commented 8 years ago

So I finally had some time to work on this. I'm not sure what your thoughts are on this but since upstream mcrouter has started adding FOLLY_COMMIT files, this is all much easier.

This PR is an attempt to accomplish two things:

1) Add support for 14.04 without breaking 12.04 support or making too many changes 2) Try to automate the builds further by pulling down the Mcrouter version and commit hash automatically. This is so that the builds could be setup via cron if desired, without having to manually add the newest SHA hash.

Currently, there is a problem upstream. The 0.15.0 (newest release as of now) does not contain the FOLLY_COMMIT file. The correct SHA with that file is actually https://github.com/facebook/mcrouter/commit/bbc2a529cd5f2a5796e4d2fadecf4db86a9ac7be

So I would suggest that we wait for their next release and do some testing then when considering merging this in or not.

msftclas commented 8 years ago

Hi @kevinquinnyo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

bmorton commented 8 years ago

Thanks for doing this! I probably won't have too much time until I get through the holidays a bit, but I'll get back to you on this as soon as I have a chance to dig in.