search

yamporg / mods

Monorepo for all mod projects.
The Unlicense
2 stars 1 forks source link

[Dynamic Darkness - Mayor issue] Screen-Tearing like lag when using Optifine #19

Open gatoborrachon opened 3 years ago

gatoborrachon commented 3 years ago

What version are you using?

Forge: 1.12.2-forge-14.23.5.2854 Dynamic Darkness: darkness-forge-1.12.x-0.4.2 Optifine: OptiFine_1.12.2_HD_U_G5

Does this issue reproduce with the latest release?

Since 0.4.2 is the latest, yes

Which other mods do you have installed?

Optifine

What did you do?

the issue is more visible when using more mods (to cause more tension (lag) in the computer), but you can try this: (videos more below)

1.- add Dynamic Darkness and Optifine 2.- Enter to a world 3.- Move from side to side

What did you expect to see?

(Without optifine) The movement is perfectly smooth: https://streamable.com/f464rf

What did you see instead?

(With optifine) you will notice a slightly screen-tearing that increases the more mods you add Dynamic Darkness and Optifine only: https://streamable.com/dn2h9k

Additional Notes

i tried a personal modpack with and without Dynamic Darkness and the screen-tearing was so noticeable, sadly i know that issues with Optifine will mostly never be fixed since it is close-source, so if you simply have no idea if this will be fixed, please write it down

Original Comment: https://www.curseforge.com/minecraft/mc-mods/dynamic-darkness?comment=48

tie commented 3 years ago

@gatoborrachon, thanks for tracking it down to Optifine! I’ve seen some reports on CurseForge regarding performance issues but didn’t know where to start since most players have huge modpacks.

That’s definitely something I’d like to fix, though I’m not sure when I’d have enough courage to dive into Optifine code (let’s hope that it’s not obfuscated).

gatoborrachon commented 3 years ago

glad to be helpful, and yeah, the only way i had in mind was to see Optifine's Code directly, and well, i can only say that anybody would need BON 2 to de-obfuscate and JD-Gui to decompile, but i think you already know this

. . . . . .

oh also, i would like to add 1 thing no related to the issue:

i have a folder with all the mods i use splited in some categories, one of them is "performance", there i have all the mods that claim be for performance (with its libraries, in another subfolder), and when i have an issue of this style, i start my binary search with each category, that's why it was easier to find the guilty mod since i know that "performance" mods are the most likely to break something, i never saw someone doing this before

CalaMariGold commented 3 years ago

heya, any updates on this issue? Players of my modpack have been experiencing it too

tie commented 1 year ago

Likely related to #40 (that was fixed in v0.5.0 release). Needs confirmation and testing w/ Optifine.