search

yamporg / mods

Monorepo for all mod projects.
The Unlicense
2 stars 1 forks source link

Overly complicated @Config usage in Dynamic Darkness (Fix included) #22

Open Rongmario opened 3 years ago

Rongmario commented 3 years ago

Here's a way to use @Config even if your mod is a coremod/mixin.

democat3457 commented 3 years ago

Unrelated but

loli

👀

tie commented 3 years ago

Yeah, it’s a rather dirty hack indeed. Thanks for giving a good reference that uses public API!

I wanted to keep the config GUI when I’ve dropped dependency on mixin. The current implementation is, uh, a temporary workaround since both config I/O and GUI require a decent amount of boilerplate, and @Config transparently handles both.

Rongmario commented 3 years ago

Yeah that's fair. I only opened this thread bc someone was getting a crash using this mod and my LoliASM, which optimizes some strings in the background.

Unrelated but

loli

👀

Yes.