search

yan-soon / pe

0 stars 0 forks source link

Logic component is not refactored to suit StonksBook #8

Open yan-soon opened 3 years ago

yan-soon commented 3 years ago

The Parser component inside the Logic component still has the name AddressBookParser instead of StronksBookParser. If intended, could be quite misleading for readers who are also acquainted with AB3.

image.png

nus-se-bot commented 3 years ago

Team's Response

Prof advised not to rename packages in Luminus announcements. Since we did not change the names of the AB3 related packages, hence the naming of the DG components remain the same.

In addition, there is no need to refactor your packages to match the naming of your product.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: According to the image below, it is written that we can keep our package names the same as AB3, however we should change our class names to reflect what they represent. Hence since AddressBookParser actually parses commands that not only have to do with the "Addressbook" portion of the the app (the contacts list) but also other features of the app (meetings, reminders, etc), a more appropriate name would be StonksBookParser, so that readers would understand that it is the over-arching parser of the StonksBook app.

image.png

Below are images to show that the said AddressBookParser is the over-arching parser of the app, and not only deals with "AddressBook" related objects.

AddressBookParser handling Meetings related features:

image.png

AddressBookParser handling Reminders related feautres:

image.png