yanc0 / beeping

HTTP Monitoring via API - Measure the performance of your servers
MIT License
262 stars 14 forks source link

beeping doesn't seem to handle 3XX error codes #34

Closed tpoindessous closed 6 years ago

tpoindessous commented 6 years ago

Hi

beeping doesn't seem to handle 3XX error codes. I tried with http://www.google.com :

Request :
{"url": "http://www.google.com/", "insecure": false, "timeout": 20}

Response :
{"http_status":"200 OK","http_status_code":200,"http_body_pattern":true,"http_request_time":41,"dns_lookup":3,"tcp_connection":5,"server_processing":30,"content_transfer":0,"timeline":{"name_lookup":3,"connect":9,"pretransfer":9,"starttransfer":40},"ssl":false}

but with curl :

$ curl -v http://www.google.com
* Rebuilt URL to: http://www.google.com/
*   Trying 173.194.79.99...
* TCP_NODELAY set
* Connected to www.google.com (173.194.79.99) port 80 (#0)
> GET / HTTP/1.1
> Host: www.google.com
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 302 Found
< Cache-Control: private
< Content-Type: text/html; charset=UTF-8
< Referrer-Policy: no-referrer
< Location: http://www.google.fr/?gfe_rd=cr&dcr=0&ei=Qr1DWs_uCsmD1gK11IT4Bw
< Content-Length: 268
< Date: Wed, 27 Dec 2017 15:33:22 GMT

Thanks !

tpoindessous commented 6 years ago

I just looked at the code and it seems that beeping is following redirection 3xx and returns status code from last seen website.

So, it's not an error, at worst, it could be a enhancement request.

Thanks !