Open yanchaoluo opened 7 years ago
Hi Yanchao,
You did a very thorough job with this homework and completed 5 tasks when only 3 were required. I have not yet learned to use the summarise () function to calculate min/max, so that code was informative for me. Your code also taught me how to use the xtable () command. I also liked the variety of graphs you used. I was not previously aware of the possibility of highlighting outliers within the theme command, which will be extremely useful in the future.
I would note however that there are several typos in your code. I also think that better labels for your graphs would improve their interpretability and aesthetic appeal. You did interpret your code at points but I think more commentary would have been useful. I'm not sure how to correct the code you asked for help for at the bottom of your assignment. But that is a good idea that I might use in the future, I'm sure you will learn very quickly that way.
Overall, my evaluation of your assignment is: check-plus.
Wade
Hello @yanchaoluo , Here are some comments on your hw03. Hope it helps!
.md
file and .Rmd
file are switched. xtable
. facet_wrap(~continent, scales="free_y")
. This makes the plot for each continent more readable. In addition, you indicated maximum and minimum values in each continent using different color and shape. It would be better to use different color for the minimum value to distinguish itself from points nearby even though the minimum point is in different shape and size (I think you wanted to show different ways of distinguish the point though). I knew the functions but I haven't tried in this way. Those will be very useful in the future.mean(lifeExp, trim=0.1)
. trim=0.1
means cutting off 10% of each end of values.Overall, I think you did a great job! I learned a new function xtable()
and new ways to visualize the data. Well done!
Hi @yanchaoluo, great job on your homework 03 👍 Here are a few things I like about it,
Recommendation:
@winnietse1018, this week you were assigned to peer review hannahdxz and estennw.
At least three tasks: Yes (5) A table and figure for each task: Yes Comments on tables/figures: Yes Reflections on Process: Yes Bonus (side-by-side layout, table formatting): xtable, attempted layout
Comments:
geom_line(aes(y=life_mean))
instead of geom_line(aes(life_mean))
. If you don't specify that the mean is meant to be plotted on the y axis, the aes()
command thinks it's supposed to be the x-axis (since that's the first argument). When in doubt, specify which arguments you are setting within the function!diff
has to do with how the ifelse
statement reads the result of the diff()
function – notice how the incorrect code uses the same numbers but skips the 1.531 right after the first 0?Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.
@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho
SHA: bfc909f7983c0b8aa99e7c389010af459c957903
Thanks.