search

yanchaoluo / STAT545-hw-Luo-Yanchao

0 stars 0 forks source link

Hw06 ready for grading #5

Open yanchaoluo opened 6 years ago

yanchaoluo commented 6 years ago

@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho

homework 6 file hm06_Luo_Yanchao.rmd hm06_Luo_Yanchao.html Thanks

arthursunbao commented 6 years ago

Hi Yanchao,

Nice to see your repo regarding the brand new homework for homework 6. Amazing work and congratulations !

I thoroughly reviewed the homework 6 of yours and my comments are below:

For the character manipulation exercise, all the questions are answered with new code base, which is very great. For your answer about what if the string has even and odd number of characters, the answer is awesome as I didn't think of that. As for the str_trim(), you did a lot of explanation use real instances, which is great. For question 6, the way you implement it is to write a whole function with if else statement to do the judgement, which is also great. I do see your efforts in working in the assignment and you must have put a lot of efforts into it.

However, there is a minor problem which is that in the 14.3.3.1 Exercises, there is some kind of error code in HTML like "a<\/span>ble<\/li>\n" which I think you may have some format error.

Also, your writing function part is great because you self-defined country based search function based on gapminder dataset shows how to plot but also how to do various kinds of regression.

Great Work!

Regards Jason

rishadhabib commented 6 years ago

Hi Yanchao Great work with this homework assignment. I think you covered all the parts really well and showed that you have learnt a lot from the classes. I also did questions 1 and 2 so it was nice to compare answers and look through your assignment. I also had similar problems with the document format as the regular expression matches were not showing up well on the md file and couldn't really solve my issues. I ended up using a html document and also an md but both files have their problems. For task 1 you really showed the differences between different functions through clear examples and not just the definitions. You also completed many more exercises than I did so I could really work through the list and see what I needed to work on. The function was also well written and helpful for someone working with the gapminder dataset. The comments throughout made it easy for me to follow what the different lines of the function were for. Overall it was fun looking through your assignment. Rishad