yanchaoluo / STAT545-hw-Luo-Yanchao

0 stars 0 forks source link

Hw08 ready for grading #7

Closed yanchaoluo closed 6 years ago

yanchaoluo commented 6 years ago

@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho

Thanks 😄

hannahdxz commented 6 years ago

Hi! @yanchaoluo

Thank you for inviting me on your GitHub. Here's my peer review for Homework 08. Hopefully you find these comments helpful!

The README file in your hw08 is very informative, you put down the list of new features that you added to the liquor app we created in class, you provided a link to the app on shiny.io, and you also listed the R scripts that you use to create the app with links to each of them. So it is very easy to understand how your shiny app works! I also like that you put down difficulties you encountered in the process, as well as the links to the resources you referred to. Good job!

It seems that your liquor app functions well on shiny.io, all the new features you mentioned in the README is implemented and working properly! I am impressed that you add much more features than this homework required. I did not do some of the features that you did, such as "Place the plot and the table in separate tabs." and "Using shinyjs to add one survey and time table." I think these features look very nice and certainly add more functionalities to your app. I will definitely incorporate those in my app in the future. Plus, the picture of liquor you used looks very cool. :100:

I can't really think of any suggestions for your app, everything is well designed and functioning well. One small thing to mention is that maybe you could add the links to the recent homework into your main README, so that it will be easier to navigate through your repository.

Overall, this is a good assignment, I hope you keep enjoying this class :)

santiagodr commented 6 years ago

Hi @yanchaoluo !!