search

yanchenglee98 / pe

0 stars 0 forks source link

PlantUML limitation disclaimer #8

Open yanchenglee98 opened 3 years ago

yanchenglee98 commented 3 years ago

Due to the limitation of plantUML, the lifeline does not end at the destroy marker. But this disclaimer only specifies it for DeleteCommandParser.

image.png

Would be good to put a disclaimer at the top of the DG stating that all PlantUML diagrams will have the same limitation

nus-se-bot commented 3 years ago

Team's Response

First sequence diagram to appear, this note applies to all sequence diagram that appears below it.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The DG does not seem to state that the Note: section applies to all. So some readers might assume each Note: section only applies to the preceding image. Would be good to put a disclaimer before any PlantUML images stating that "The lifeline for any object should end at the destroy marker (X) but due to a limitation of PlantUML, the lifeline reaches the end of diagram." to make it more explicit that this note affects all sequence diagrams done in PlantUML.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]