search

yandex-cloud / cq-source-yc

Yandex Cloud CloudQuery source plugin
https://hub.cloudquery.io/plugins/source/yandex-cloud/yc
Apache License 2.0
18 stars 11 forks source link

Add dns fetch functionality #38

Closed Maunty closed 4 months ago

Maunty commented 1 year ago

Table resources were generated according to already impemented machinery.

Iteration via dns zones for records fetch are implemented as embeded table via machinary.

Primary key for records table was formed over zone_id+name+type colums. In order to implement this i was forced to skip fields name and type and define required colums as extraColums. Dont sure if this is optimal way of implementation provided by CQ.

Maunty commented 1 year ago

@kabachook CI is awaiting some approve actions. I am not familiar with GH Actions, my PR doesn't contain changes of any CI related configurations, so this is not related to its content. Hope you can find some time to solve this issue.

I would be happy to have this functionality in upstream.

kabachook commented 1 year ago

Hi, @Maunty! Since i'am not a maintainer my approve doesn't trigger CI checks or allow to merge. @GennadySpb @valyankilyan please review

kabachook commented 7 months ago

Hi, @Maunty. Due to internal refactor this has been implemented in https://github.com/yandex-cloud/cq-source-yc/commit/ac5dfca499820b151fc5de961edd211e35897687. It will be published in v1 release soon.

kabachook commented 4 months ago

@Maunty Released https://github.com/yandex-cloud/cq-source-yc/releases/tag/v1.0.0