Closed nikolaymatrosov closed 9 months ago
@DmitryNaumov can you review, please?
@nikolaymatrosov will be back with feedback next week
@nikolaymatrosov @DmitryNaumov hello, could you please inform on the status of this pull request?
@nikolaymatrosov I have some minor concerns about this PR:
- This new provider adds new very specific dependencies to base package. These dependencies may cause versioning issues in future, if any of them will have major version released. Imo it would be better to release this provider as separate package to minimize dependencies in base package.
It is a part of core functionality every YC SDK written in other language has. I think it is good to have feature parity between all SDKs.
- Having private key committed in code looks 'ugly' even in tests. I wonder if it may produce false security alerts from some tools. Is it possible to generate it on the fly during the tests?
I changed tests, so the key is now generated.
Hi, are there any updates for this PR?
This pull request, having been initiated an extensive duration ago, has consequently become antiquated. Therefore, in recognition of its second anniversary, I have resolved to formally conclude it.
Need tests