yandex-cloud / python-sdk

Yandex.Cloud Python SDK
MIT License
75 stars 24 forks source link

Add test/lint in protogenerate workflow #52

Closed l0kix2 closed 2 years ago

l0kix2 commented 2 years ago

As far as I understand, the google protobuf library creates some objects and puts them on module level at import time. Pylint is not happy with it, but those names are importable in fact.

1) I added linter exception for this kind of problem, it seems that we will have more false positives here than useful alerts. 2) I added tests & linting in protogeneration workflow, so we have a green master and won't have a situation, when honest developer tries to make small change and have to deal with broken builds like it happened here https://github.com/yandex-cloud/python-sdk/pull/51

PS I do not know why python 3.6 not fails, i guess pylint may cut it from the newest versions of the library and check not happening in old version of pylint. Haven't chance to debug this behavior, can't install python3.6 on my macbook (only pythons 3.7+).