yandex-qatools / postgresql-embedded

Embedded PostgreSQL Server
Other
493 stars 90 forks source link

Compliance with jdk9 #118

Closed dzmitryh closed 6 years ago

dzmitryh commented 6 years ago

While migrating our service to jdk9 I see that internal lib(de.flapdoodle.embed.process.runtime.Processes) throws silent exception:

java.lang.NoSuchMethodException: java.lang.Process.getPid()
    at java.base/java.lang.Class.getMethod(Class.java:2065)
    at de.flapdoodle.embed.process.runtime.Processes$PidHelper$1.getPid(Processes.java:195)
    at de.flapdoodle.embed.process.runtime.Processes.processId(Processes.java:72)
    at de.flapdoodle.embed.process.runtime.ProcessControl.<init>(ProcessControl.java:64)
    at de.flapdoodle.embed.process.runtime.ProcessControl.start(ProcessControl.java:205)
    at de.flapdoodle.embed.process.runtime.AbstractProcess.<init>(AbstractProcess.java:98)
    at ru.yandex.qatools.embed.postgresql.AbstractPGProcess.<init>(AbstractPGProcess.java:19)
    at ru.yandex.qatools.embed.postgresql.PostgresProcess.<init>(PostgresProcess.java:68)
    at ru.yandex.qatools.embed.postgresql.PostgresExecutable.start(PostgresExecutable.java:25)
    at ru.yandex.qatools.embed.postgresql.PostgresExecutable.start(PostgresExecutable.java:13)
    at de.flapdoodle.embed.process.runtime.Executable.start(Executable.java:101)

I think it is because of https://github.com/flapdoodle-oss/de.flapdoodle.embed.process/issues/57

So are there any plans to upgrade internal helper library to be complaint with jdk9 ? Let me know is smth is unclear ;)

ljarman01 commented 6 years ago

+1 looks like the flapdoodle libs just got updated to 2.0.2 so they just need to be put up on maven central so that dep can be added here.

kulabun commented 6 years ago

+1