search

yandex-qatools / postgresql-embedded

Embedded PostgreSQL Server
Other
494 stars 90 forks source link

Use up to date process embed version to be compatible with Java 9+. #152

Closed marshallpierce closed 5 years ago

marshallpierce commented 5 years ago

Also, add commons-io dependency -- it used to be a transitive dependency from the old version of process embed, but it's used directly.

mgreene commented 5 years ago

@marshallpierce Awesome! Were you building against JDK 11?

marshallpierce commented 5 years ago

Yep, java 11.

cademarkegard commented 5 years ago

awesome! I was just attempting to upgrade a project to 11 that depends on this project. Is there anything I can do to help get this through the review process?

Additionally, is it possible for us to enable JDK 11 on TravisCI also? https://docs.travis-ci.com/user/languages/java/#using-java-10-and-later

smecsia commented 5 years ago

This looks good to me. And I agree with @cademarkegard, could you add JDK 11 configuration for Travis?

NielsDoucet commented 5 years ago

Any chance of this being merged and released in the near future? We're looking at a migration path towards java 11 and this is one of the final hurdles.

poxu commented 5 years ago

Same here. We're migrating to jdk 11 as soon as this pull request is merged. Please release a new version right after the merge! ))

mgreene commented 5 years ago

Just as an FYI, I built @marshallpierce's fork and uploaded the artifact to my nexus repo while this is being reviewed. It's been working on our builds for over a month now.

SButterfly commented 5 years ago

Hi @smecsia . Could you please release new version of postgresql-embedded with this fix?