frontend.c: fix refcnt at function stack

yandex / odyssey

Scalable PostgreSQL connection pooler

BSD 3-Clause "New" or "Revised" License

3.21k stars 165 forks source link

Closed rkhapov closed 2 months ago

rkhapov commented 2 months ago

There are three problems:

hashmap element is freed by free(value.data), which means calling free at pointer in stack, which will case SIGSEGV randomly
*refcnt + 1 at else branch can cause to random stack bytes rewritting
this can led to some random values at 'show server_prep_stmts'

rkhapov commented 2 months ago

no, the content of value.data is copied, so it works well