yandex / ozo

OZO is a C++17 Boost.Asio based header-only library for asyncronous communication with PostgreSQL DBMS.
PostgreSQL License
227 stars 46 forks source link

Fix test instructions #248

Closed jonesmz closed 4 years ago

jonesmz commented 4 years ago

Another change I could make a PR for is to modify

make -j$(nproc)

to

cmake --build . --parallel $(nproc) --verbose --clean-first

Which is a more idomatic way to build cmake projects.

jonesmz commented 4 years ago

Do you want me to add another commit to change it to cmake --build . --parallel $(nproc) --verbose --clean-first ?

Or would you rather leave it as make ?

thed636 commented 4 years ago

@jonesmz would it be nice to add it as a separate recommendation to simplify and speed up the process?

jonesmz commented 4 years ago

The reason someone might want "cmake --build ." is because they won't need to know anything about the generator that cmake defaulted to on the current platform.

Theres:

and others

thed636 commented 4 years ago

Yes, that’s a good reason, let’s add it instead of make.

jonesmz commented 4 years ago

Just to confirm you're looking to have me make a PR that adds cmake --build . --parallel $(nproc) --verbose --clean-first to the instructions?

thed636 commented 4 years ago

Yes, sure. I just merged this PR, since it was approved.