ABI backward compatibility with RE_VERSION 6

yandex / pire

Perl Incompatible Regular Expressions library

http://github.com/dprokoptsev/pire/wiki

Other

330 stars 30 forks source link

ABI backward compatibility with RE_VERSION 6 #32

Closed starius closed 8 years ago

starius commented 8 years ago

Fix reading scanners serialized with previous PIRE version (RE_VERSION 6).

davenger commented 8 years ago

This needs unittests that check that it works properly with scanners saved with the previous version.

dprokoptsev commented 8 years ago

It needs more than that. What I am curious to find out is your vision of how Pire should handle ABI changrs in general, to make sure we're not going to end up having a huge bunch of elseifs handling all possible format versions.

Perhaps we should hold it for a little while and discuss things verbally.

starius commented 8 years ago

A fix and a unittest were added.