search

yandex / pire

Perl Incompatible Regular Expressions library
http://github.com/dprokoptsev/pire/wiki
Other
330 stars 30 forks source link

Allow to do serializing in machine-independent format #45

Closed sorc1 closed 8 years ago

sorc1 commented 8 years ago

The patches introduce Pack()/Unpack() functions for Multi scanner to serialize/deserialize with msgpack.

sorc1 commented 8 years ago

21.09.2016 03:39, Boris Nagaev wrote:

@starius requested changes on this pull request.

General comments:

  1. Style: add braces around one line blocks, please.
  2. Why not protocol buffer?

Some reasons for that:

  1. No extra build dependencies
  2. The format is not going to change often
  3. It's just simple: while packing/unpacking, we're working directly with the scanner instance's memory, not with objects-to-serialize

I'll fix the problems you've pointed on and then I'll resend the patches.

sorc1 commented 8 years ago

46