search

yandex / pire

Perl Incompatible Regular Expressions library
http://github.com/dprokoptsev/pire/wiki
Other
330 stars 30 forks source link

AdvancedCountingScanner as an alternative to CountingScanner #49

Closed kv75 closed 6 years ago

kv75 commented 6 years ago

There are 3 main differences, see unit tests.

  1. AdvancedCountingScanner never enters a dead state, see test Count("[a-z\320\260-\321\217]+", " +", " \320\260\320\260\320\220 abc def \320\260 cd")
  2. AdvancedCountingScanner returns 1 for Count("a", "b", "aaa"), while CountingScanner returns 0 there.
  3. AdvancedCountingScanner better handles complex regular expressions, see test CountGreedy.
moskupols commented 6 years ago

Looks Good To Me.

sergey-v-galtsev commented 6 years ago

Looks Good To Me.