yandex / rep

Machine Learning toolbox for Humans
http://yandex.github.io/rep/
Other
687 stars 144 forks source link

Grid_search doensn't use metric prefitting #12

Closed arogozhnikov closed 9 years ago

arogozhnikov commented 9 years ago
estimator = SklearnClassifier(GradientBoostingClassifier(n_estimators=15), features=features)
grid_finder = GridOptimalSearchCV(estimator, generator, scorer)
grid_finder.fit(data, labels)

results in

---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
 in ()
      1 estimator = SklearnClassifier(GradientBoostingClassifier(n_estimators=15), features=features)
      2 grid_finder = GridOptimalSearchCV(estimator, generator, scorer)
----> 3 grid_finder.fit(data, labels)

/Users/axelr/ipython/rep/rep/metaml/gridsearch.py in fit(self, X, y, sample_weight)
    530                 state_indices, state_dict = self.params_generator.generate_next_point()
    531                 status, value = apply_scorer(self.scorer, state_dict, self.base_estimator, X, y, sample_weight)
--> 532                 assert status == 'success', 'Error during grid search ' + str(value)
    533                 self.params_generator.add_result(state_indices, value)
    534                 self.evaluations_done += 1

AssertionError: Error during grid search 'RocAuc' object has no attribute 'classes_'
arogozhnikov commented 9 years ago

resolved in https://github.com/yandex/rep/commit/6d291c1913c2c5a2220a219e653f5d754c665bc8